Problem/Motivation

Follow-up to #3568641: [CI] Introduce our own PHPStan ErrorFormatter to avoid multiple PHPStan executions

Address a couple of suggestions that did not make into the MR:

1) #3568641-43: [CI] Introduce our own PHPStan ErrorFormatter to avoid multiple PHPStan executions by @godotislate

wondering whether the file handling should be done with SplFileObject instead of a resource

2) #3568641-48: [CI] Introduce our own PHPStan ErrorFormatter to avoid multiple PHPStan executions by @mondrake

How about passing a null here table: ~ so that if the null is detected, the upstream $output is used in the multiplexer

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3575080

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

quietone’s picture

quietone commented
Version: 11.x-dev » main

mondrake opened merge request !14865

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Maybe out of scope here, but what do we think about moving this code to the \Drupal\Component namespace and making it a standalone component? It definitely feels like code that other PHPStan users might want to use, but also we've not really done anything similar with components in the past.

mondrake’s picture

mondrake
Location 🇮🇹
commented

#4 or move it to a separate project entirely? I was thinking phpstan-drupal, but that's too Drupalish anyway.

In Slack I was kinda trying to suggest it could be taken by PHPStan upstream, but I do not think we moved the maintainer...

Would need an issue of its own, I suppose.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Oh man please! Sometimes it's straight forward and sometimes it's not

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 70bbe3baf91 to main and 8d0478b5687 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • longwave committed 8d0478b5 on 11.x 
    ci: #3575080 [CI] Enhance PHPStan ErrorFormatter

By: mondrake
(cherry...

  • longwave committed 70bbe3ba on main 
    ci: #3575080 [CI] Enhance PHPStan ErrorFormatter

By: mondrake

longwave closed merge request !14865

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.