Problem/Motivation

Enabling the module executes a migration script which converts existing content reminders from Config Entities to Content Entities. This was done to convert content reminders that were created by a custom module.

Within the script, a check of the which class/interface the existing content reminder object is fails, which leads to variables not being defined.

The cause is that the existing content reminders are actually instances of \Drupal\custom_content_reminders_module\ContentReminderInterface while the script is checking them against \Drupal\content_reminders\ContentReminderInterface (from the contrib module).

Steps to reproduce

Enable the content reminders module.

Proposed resolution

Check that the existing content reminders are instances of ConfigEntityBase, the parent class of the ContentReminder class. The ContentReminder class also implements ContentReminderInterface.

This should work because all existing content reminders are instances of ConfigEntityBase so there is no cross module conflict.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork content_reminders-3574702

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

theloneliestmonk created an issue. See original summary.

theloneliestmonk opened merge request !15

timozura closed merge request !15

timozura’s picture

timozura commented
Status: Active » Closed (outdated)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.