Related to #355225: Inconsistant Insert Queries Between Database Drivers: we mandate multi-values insert queries to be atomic on all engines that support transactions, and this is the case of SQLite. For this to work, we need to explicitly add ON CONFLICT ROLLBACK to our insert queries (the default is ON CONFLICT ABORT that just abort the current query).

CommentFileSizeAuthor
#1 357470-sqlite-insert-rollback.patch2.23 KBdamien tournoud

Comments

damien tournoud’s picture

damien tournoud commented
Status: Active » Needs review
StatusFileSize
new 357470-sqlite-insert-rollback.patch2.23 KB

Here we are.

damien tournoud’s picture

damien tournoud commented
Status: Needs review » Needs work
Crell’s picture

Crell commented

Why was this set back to needs work? Are we going to resolve this in D7, or push it to D8?

catch’s picture

catch
he/him
Primary language English
commented
Priority: Critical » Normal

Downgrading, this is a straight bug.

ddorian’s picture

ddorian commented
Status: Needs work » Needs review

#1: 357470-sqlite-insert-rollback.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 357470-sqlite-insert-rollback.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
commented

This could be used to fix #715108: Make Merge queries more consistent and robust
http://www.sqlite.org/lang_conflict.html

damien tournoud’s picture

damien tournoud commented
Status: Needs work » Closed (won't fix)

Actually, no. We fixed the base implementation to properly rollback in case of error.