Problem/Motivation

Looking through all core module, there are quite a few forms that are safe to be submitted in a workspace, but are currently blocked.

Proposed resolution

Mark them as workspace-safe.

Remaining tasks

Review.

User interface changes

Nope.

Issue fork drupal-3573938

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

amateescu created an issue. See original summary.

amateescu opened merge request !14788

amateescu’s picture

amateescu commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems straight forward to me.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review

Are the revision delete and revert forms really workspace safe?

amateescu’s picture

amateescu commented
Status: Needs review » Reviewed & tested by the community

They are, in the sense that there's no difference if you delete or revert a revision in Live or in a workspace.

In the functional sense, we currently have a bug when you delete the latest workspace-tracked revision: #3514157: Deleting latest of multiple workspaced revisions deletes workspace association

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review

They are, in the sense that there's no difference if you delete or revert a revision in Live or in a workspace.

But if you revert a revision, what happens is it creates a new revision from an old one, it ought to be possible to track that in a workspace, if it's currently not, then it doesn't feel very workspace-safe.

smustgrave’s picture

smustgrave commented

@amateescu thoughts on the last comment?

amateescu’s picture

amateescu commented
Status: Needs review » Reviewed & tested by the community

@catch, I just tried that manually in the UI, and everything is working as it should.

When you're in a workspace and revert to an older revision, the new revision that's created is tracked in that workspace. Also, when deleting a workspace-tracked revision, that revision (aside from the being deleted) is no longer tracked in the workspace_association_revision table.

  • catch committed ab1e133d on 11.x 
    task: #3573938 Mark more forms as workspace-safe

By: amateescu
(cherry...

  • catch committed 1ad7e6c5 on main 
    task: #3573938 Mark more forms as workspace-safe

By: amateescu
catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

OK that makes sense, if the new revision is tracked, then it's working how it should. We should probably revisit #2899719: Revision/version language on revision listing page is misleading with content moderation enabled at some point since the revision revert behaviour isn't very self-explanatory especially with content moderation or workspaces installed, but it's also not self-explanatory why you wouldn't be able to use that form either so we're only making things better here.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !14788

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.