Problem/Motivation

Remove D12 deprecated code from views and views Ui modules

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3573869

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

sourav_paul made their first commit to this issue’s fork.

sourav_paul opened merge request !14815

sourav_paul’s picture

sourav_paul
Location Kolkata
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Only reviewed the first file but did you check what the deprecations are removing or just removed the trigger_errors?

Also MR should be passing before review.

smustgrave’s picture

smustgrave commented

Also there may be tests that were testing these deprecations.

smustgrave opened merge request !14852

smustgrave’s picture

smustgrave commented

Opened a new MR as the previous one had too many changes to see what overlapped and what was missing.

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review
dcam’s picture

dcam commented
Status: Needs review » Needs work

I made lots of comments.

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

Addressed the feedback and commented back where I could

dcam’s picture

dcam commented
Status: Needs review » Needs work

I left new comments, mostly saying that the difficult things should be removed from the scope of this issue. The MR is big enough. Having to deal with difficult problems here might result in delays and rebases. Though most of these changes are to template files that don't change much.

dcam’s picture

dcam commented

Moving difficult changes to follow-ups should also help everyone focus on them better. There are too many changes with multiple difficult problems for that to happen otherwise. Everything else will be a distraction. Let's get the easy stuff in and worry about the hard stuff later.

smustgrave’s picture

smustgrave commented
Assigned: Unassigned » smustgrave

Sure I’ll take care of tomorrow

sourav_paul’s picture

sourav_paul
Location Kolkata
commented

Thanks @smustgrave for picking this up and pushing it forward while I was tied up with project work — really appreciate it.

I’ve gone through the latest changes and everything looks good.

Please let me know if there’s anything further I can help with on this issue.

smustgrave closed merge request !14815

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review
dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Thank you @smustgrave. All feedback has been addressed.

smustgrave’s picture

smustgrave commented

Rebased

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
Status: Reviewed & tested by the community » Needs work

Merge conflicts must be resolved.

smustgrave’s picture

smustgrave commented
Status: Needs work » Reviewed & tested by the community

Rebased

  • catch committed a71a3edf on main 
    task: #3573869 Remove deprecated code from Views and Views UI

By:...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !14852

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.