Problem/Motivation

Remove D12 deprecated code from workspace and workspace ui modules

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3573868

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

amateescu made their first commit to this issue’s fork.

amateescu opened merge request !14787

amateescu’s picture

amateescu commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

There may be some tests that have to be fixed up.

amateescu’s picture

amateescu commented
Status: Needs work » Needs review

All good now :)

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Thanks! LGTM!

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 686e984d29b to main. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • longwave committed 686e984d on main 
    task: #3573868 Remove deprecated code from Workspaces and Workspace UI...

longwave closed merge request !14787

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Didn't spot this in .deprecation-ignore.txt:

%The "Drupal\\workspaces\\WorkspaceManager::setActiveWorkspace\(\)" method will require a new "bool \$persist" argument in the next major version of its interface%

We can clean that up in a followup.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

amateescu’s picture

amateescu commented

For posterity, that cleanup was done in #3576579: Tidy up and tighten deprecation ignores and tests marked #[IgnoreDeprecations] where no deprecations are triggered.