Problem/Motivation

PHP 8.4 has deprecated implicit nullable types.

FILE: ../docroot/modules/contrib/cookiepro/src/Form/HeaderForm.php
------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------
 31 | WARNING | Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $request.
------------------------------------------------------------------------------------------------

Steps to reproduce

Use in a PHP 8.4 environment.
phpcs -d memory_limit=-1 --standard=PHPCompatibility --runtime-set testVersion 8.4 --extensions=php,module,inc,install,theme -p docroot/modules/contrib/cookiepro/

Proposed resolution

The request variable is not being used. I guess we can remove this safely.

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork cookiepro-3573785

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jaswinsingh created an issue. See original summary.

jaswinsingh opened merge request !5

jaswinsingh’s picture

jaswinsingh commented
Status: Active » Needs review
guiu.rocafort.ferrer’s picture

guiu.rocafort.ferrer
Primary language Spanish
Location Barcelona
commented
Status: Needs review » Reviewed & tested by the community

Reviewed and tested MR5, since the $request variable was not being used anywhere in the method, i think it is better to just remove it from the parameters definition. RTBC.

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented

Fixed as part of #3429580: Automated Drupal 11 compatibility fixes for cookiepro. Thank you! Credits awarded ✅

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.