Problem/Motivation

At the moment, PDFToImageBatchHelper uses only static methods. In general, it works, but it's much better to rework it to follow the Drupal way.

Proposed resolution

- Add DependencySerializationTrait to the PDFToImageBatchHelper class.
- Rework the methods of the helper to non-static
- Update PDFToImageManager::initConversion

Issue fork pdf_to_imagefield-3573450

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hitchshock created an issue. See original summary.

hitchshock’s picture

hitchshock
Location Ukraine
commented
Assigned: Unassigned » hitchshock

hitchshock opened merge request !13

hitchshock’s picture

hitchshock
Location Ukraine
commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • hitchshock committed 18a24a92 on 1.0.x 
    [#3573450] Refactored PDFToImageBatchHelper and fixed errors

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.