Problem/Motivation

When building the metabox field group, the current logic does not account for fields that are already in a #group. These fields may be unintentionally reassigned to metabox_fields and breaking the form structure. We've run into this with the Scheduler module.

Steps to reproduce

  • Install and configure Scheduler for a Gutenberg enabled content type.
  • The related fields are now in the More settings area, instead of the Scheduler group.

Proposed resolution

Ensure form items that have a group assigned to are not moved into metabox_fields.

Remaining tasks

Add MR.

Issue fork gutenberg-3573342

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

aimai created an issue. See original summary.

aimai opened merge request !233

aimai opened merge request !234

  • codebymikey committed fbf8814e on 8.x-2.x authored by aimai 
    fix: #3573342 Prevent overriding existing #group when moving fields to...

  • codebymikey committed 5d8c4f67 on 3.0.x authored by aimai 
    fix: #3573342 Prevent overriding existing #group when moving fields to...
codebymikey’s picture

codebymikey commented
Issue summary: View changes
Status: Active » Fixed

Thanks for the fix!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

codebymikey’s picture

codebymikey commented
Related issues: +#3096002: Support Field Groups

  • codebymikey committed 5d8c4f67 on 4.0.x authored by aimai 
    fix: #3573342 Prevent overriding existing #group when moving fields to...

  • codebymikey committed 5d8c4f67 on feature/wp-scripts-packages-build authored by aimai 
    fix: #3573342 Prevent overriding existing #group when moving fields to...

aimai opened merge request !240

aimai opened merge request !241

  • codebymikey committed 168b60b8 on 8.x-2.x authored by aimai 
    fix: #3573342 Prevent overriding group

By: aimai
By: codebymikey

  • codebymikey committed 5c8c5387 on 3.0.x authored by aimai 
    fix: #3573342 Prevent overriding group

By: aimai
By: codebymikey

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.