Problem/Motivation

Current JS is causing test failures due to dragTo() conflict, and also has performance issues. Needs to be investigated & improved.

Issue fork lms-3573214

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ob3ron created an issue. See original summary.

nickolaj made their first commit to this issue’s fork.

nickolaj opened merge request !147

nickolaj’s picture

nickolaj
Primary language Ukrainian
commented
Status: Active » Needs review

Patch replaces manual `data-lmsDragInit` guard with Drupal's `once()` API (already a declared dependency), tracks hover target in a single variable instead of querying all `.drag-over` elements on every move/end event, fixes `touchstart` target detection to use `.closest()`, makes `touchstart` passive, removes template literals for IE/older WebView compat, and improves `dragleave` to ignore child-to-parent bubbling.

graber made their first commit to this issue’s fork.

graber opened merge request !148

graber’s picture

graber commented

Thanks @nickolaj, I added extended automated tests from #3572168: Drag-and-drop test coverage in a second branch, let's see if it'll be a pass..

ob3ron’s picture

ob3ron commented
Assigned: ob3ron » Unassigned
Status: Needs review » Reviewed & tested by the community

@nickolaj thank you for lending your expertise to give a professional finish to my hackery. 😁 It works for me in all of the ways I've tested it.

graber’s picture

graber commented

Merging this without test coverage for now, there are some things that need resolving there and I don't want to block this.

  • nickolaj committed 65efa538 on 1.1.x 
    Issue #3573214: Patch replaces manual `data-lmsDragInit` guard wit...
graber’s picture

graber commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.