Problem/Motivation

The version block loads the library navigation_extra_version. In the frontend view, so no admin context (/admin), the library is executed correctly. But in admin context, the check if (context === document) is not correct.

Steps to reproduce

Install the module
Place the block
Load frontend and see everything is correct
Load the backend and see the check blocks the execution of the once

Proposed resolution

Remove the check, as I don't see the value for it?

Remaining tasks

Create MR

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork navigation_extra-3572899

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tim-diels created an issue. See original summary.

tim-diels opened merge request !18

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Active » Needs review
dtfabio’s picture

dtfabio commented
Assigned: Unassigned » dtfabio
dtfabio’s picture

dtfabio commented
Assigned: dtfabio » Unassigned
Status: Needs review » Reviewed & tested by the community

Hi Tim,

I tested the code change on three different Drupal instances.

Drupal core versions: 10.3.14, 10.6.3 and 11.3.3
PHP versions: 8.3.30 (10.3) and 8.4.18 for the newer core versions.
Database version: MariaDB 11.8.6

The problem only occurred on version 11.3.3, but I tested whether the patch would break anything on older versions and found no difference.

The icon does not change colour before adding the patch, but it does after adding the patch, so I think this ticket can be moved to RTBC.

Greetings,

Fabio

  • tim-diels committed 14abb935 on 1.0.x 
    fix: #3572899 Version library does incorrect check

By: tim-diels
By:...
tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.