Problem/Motivation

Need to drop support for Drupal 9.5 in the next major version.

Proposed resolution

I suggest introducing branch 3.x, which will support Drupal >= 10. And keep 2.x with Drupal 9.5 support for bug fix only.

Additionally:
In case version 9.5 support is removed, then there is no need for '#default_value'; instead, use '#config_target'. Simplifies the form; there is no need for implementing submitForm; that would be handled in the base class.

Issue fork friendship-3572257

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

vitaliyb98 created an issue. See original summary.

nickolaj made their first commit to this issue’s fork.

nickolaj opened merge request !13

nickolaj’s picture

nickolaj
Primary language Ukrainian
commented
Status: Active » Needs review

Dropped Drupal 9.5 from core_version_requirement and replaced `#default_value` with `#config_target` in FriendshipSettingsForm, removing the now-unnecessary custom `submitForm()` override.

vitaliyb98’s picture

vitaliyb98 commented
Status: Needs review » Fixed

Hi @nickolaj, thanks for your works

Merged into 3.x

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.