Problem/Motivation

There is an error on Modal 5.1 and D11

On fresh install
Drupal 11
Modal 5.1.x
After the install via composer and drush en modal_page
There is an error related to js_cookie
I didn't investigate better yet
I'm reporting just to have that tracked
Is necessary to update the issue description soon

Issue fork modal_page-3572172

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

renatog created an issue. See original summary.

renatog’s picture

renatog commented

Probably related to #3563079: Error during the install 5.1.x - js_cookie does not exist

nickolaj made their first commit to this issue’s fork.

nickolaj opened merge request !73

nickolaj’s picture

nickolaj
Primary language Ukrainian
commented
Status: Active » Needs review

The `core/js-cookie` library was deprecated in Drupal 10.1 and removed in Drupal 11, causing this error. This patch replaces the dependency with the `drupal/js_cookie` contrib module, matching the approach already used in the 6.0.x branch.

renatog’s picture

renatog commented

@nickolaj thanks for your contribution

Hey, your MR really seems good!

I'm going to add that at #3553252: Plan for the next Modal Releases

renatog’s picture

renatog commented
Parent issue: » #3553252: Plan for the next Modal Releases

  • nickolaj committed e6497806 on 5.1.x 
    Issue #3572172: The `core/js-cookie` library was deprecated in Dru...
renatog’s picture

renatog commented
Status: Needs review » Fixed
Issue tags: -Needs issue summary update

Merged and launched a new version with this

Public thanks in the release notes for your contribution @nickolaj

https://www.drupal.org/project/modal_page/releases/5.1.8

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

alfattal’s picture

alfattal commented
Priority: Normal » Major
Status: Fixed » Needs work

This actually caused the upgrade to version 5.1.8 to fail on Drupal 10 with the error message "Unable to install the Modal module since it requires the JavaScript Cookie Library module" when running drush si. Please fix or provide a path for successful upgrade.

renatog’s picture

renatog commented
Priority: Major » Normal
Status: Needs work » Fixed

This actually caused the upgrade to version 5.1.8 to fail on Drupal 10 when running drush si

Could be a side-effect, please report a separated issue

  • This one is already merged at dev branch (5.1.x) and released at 5.1.8
  • It fixes the issue described on IS
  • There is a possibility that caused the problem mentioned with drush si
  • However, please report a new issue at: https://www.drupal.org/node/add/project-issue/modal_page
  • If necessary you can use the field "Related issues" to link with this one

Please fix or provide a path for successful upgrade

@alfattal same request for you

Let's keep in mind that here is an open-source community
@nickolaj had a nice contribution providing a solution
If possible do the same
Instead of asking fixes for others, go ahead and provide a patch with the solution
Thanks

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.