Problem/Motivation

After updating from 3.0.0-beta2 => 3.0.0 Drupal is logging to PHP issues:

  • User warning: The following theme is missing from the file system: jquery_deprecated_functions
  • Deprecated function: dirname(): Passing null to parameter #1 ($path) of type string is deprecated

Proposed resolution

I did a review of the changes to the code base between 3.0.0-beta2 => 3.0.0 and noticed a new hook was added along with the work to use OOP hook Implementations. The new hook class function `jqueryDeprecatedFunctionsPageAttachments`. This function attaches the `jquery_deprecated_functions/global-scripts` library, but this library does not exist. I am making an educated guess that this library was used during development and should not have made it into the code base, and should be removed.

CommentFileSizeAuthor
#5 3572020-issue-screen.png183.03 KBdanrod

Issue fork fluidui-3572020

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

littlecoding created an issue. See original summary.

danrod’s picture

danrod
Location Ottawa
commented
Priority: Normal » Critical
danrod’s picture

danrod
Location Ottawa
commented

Thanks for reporting this, I have no idea how this hook class ended up here, but your guess may be right, I'll fix it and create a new release today.

Sorry for replying to this a bit late, had a lot of work on the side.

Again, thanks and sorry for this inconvenience. I changed the priority as "Critical".

danrod opened merge request !53

danrod’s picture

danrod
Location Ottawa
commented
StatusFileSize
new 3572020-issue-screen.png183.03 KB

Taking a look again at this issue and I can see the warnings:

PHP Warning of some stale code that should not be there

I am preparing a new release for fixing this.

danrod’s picture

danrod
Location Ottawa
commented

I created a new release to fix this: https://www.drupal.org/project/fluidui/releases/3.0.1

Hopefully this will get rid of the extra PHP warning.

Thanks a lot @littlecoding for pointing this out.

I tested it myself and I don't see the warning anymore, and the module seems to function as expected, so I took the liberty to mark as "Fixed", but please let me know if you still see any issues with this.

danrod’s picture

danrod
Location Ottawa
commented
Status: Active » Reviewed & tested by the community
danrod’s picture

danrod
Location Ottawa
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.