Problem/Motivation

Adding two new images in content in a row, user is able to manually check more than 1 image.

Steps to reproduce

1. Enable Media library module
2. Add a field media to a basic page
3. Add a basic page
4. Add new image from computer
5. Add another new image from computer right away
6. Now you'll be able to check all the other media listed even field not supporting them

Check video attached.

Proposed resolution

Just make the actual selection interactive with the user.

Remaining tasks

- PR
- Test

User interface changes

Limits the user iteration on specific scenario.

Introduced terminology

NA

API changes

NA

Data model changes

NA

Release notes snippet

NA

Issue fork drupal-3571849

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

julio_retkwa created an issue. See original summary.

julio_retkwa’s picture

StatusFileSize
new876 bytes

julio_retkwa’s picture

Status: Active » Needs review
dcam’s picture

Status: Needs review » Needs work
Issue tags: +Needs tests

Thank you for your work to improve Drupal!

This smells like a bug to me, but whether it is or not the change should be tested.

julio_retkwa’s picture

Status: Needs work » Needs review
Issue tags: -Needs tests
julio_retkwa’s picture

Issue summary: View changes
julio_retkwa’s picture

Issue tags: +bug
smustgrave’s picture

Category: Task » Bug report
Issue tags: -bug
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Bug Smash Initiative, +Needs Review Queue Initiative
StatusFileSize
new308.59 KB

bug

So the issue described is reproducable and MR fixes it.

Do want to mention following the steps though, where you continuously upload images you can add more then the limit. May be a separate issue.

  • amateescu committed 00e559fe on 11.3.x
    fix: #3571849 Media Library allows user to select more media than...

  • amateescu committed c91a1b78 on 11.x
    fix: #3571849 Media Library allows user to select more media than...

  • amateescu committed fc58a46e on main
    fix: #3571849 Media Library allows user to select more media than...
amateescu’s picture

Status: Reviewed & tested by the community » Fixed

Manually tested and confirmed the problem, nice one :) @smustgrave, yep, that's another issue.

Committed and pushed fc58a46e636 to main and c91a1b78e7c to 11.x and 00e559fed67 to 11.3.x. Thanks!

Backported to 11.3.x as a non-disruptive bug fix.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.