Problem/Motivation

Not just the title field should be able to support soft hyphens.

Steps to reproduce

Not applicable.

Proposed resolution

Implement the feature as a field widget for string fields. This would make the feature available for multiple fields.

Remaining tasks

  1. POC
  2. Review
  3. Iterate
  4. Accept merge request
  5. Tag new release

User interface changes

A new field widget for fields of type string will be added.

API changes

Use of modern Drupal best practices would require a change to the module core_version_requirement. From ^10 | ^11 to ^10.2 | 11^.

Data model changes

None.

Issue fork unicode_soft_hyphens-3571567

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

peter törnstrand created an issue. See original summary.

peter törnstrand’s picture

peter törnstrand commented
Title: Implement as a FieldFormatter to support all string fields » Implement as a FieldWidget to support all string fields
Issue summary: View changes
peter törnstrand’s picture

peter törnstrand commented
Issue summary: View changes
peter törnstrand’s picture

peter törnstrand commented
Issue summary: View changes
guido_s’s picture

guido_s
Location Cologne
commented

We only had the need for titles and labels as it's possible to use HTML on other fields. But if it's of use to you for other fields too, I'll gladly review any merge request.
At least I assume you want to work on this, as you assigned the issue to you.

peter törnstrand’s picture

peter törnstrand commented

Yes, I have a merge request on the way.

peter törnstrand’s picture

peter törnstrand commented
Assigned: peter törnstrand » Unassigned
Status: Active » Needs review

So I might have gone a bit out of scope on this... I converted all hooks to the new system and documented the functions in the JS file. The new CSS files does not use a CSS preprocessor so Gulp could be removed if this MR is accepted.

peter törnstrand opened merge request !2

peter törnstrand’s picture

peter törnstrand commented
Issue summary: View changes

Since this MR bumps the lowest supported core version to 10.2 from 10.x this should perhaps, if accepted, go into a 2.x release.

guido_s’s picture

guido_s
Location Cologne
commented

Yes, this is really out of scope of this issue / feature request.
All the additional stuff makes it really hard to check.
I want to keep minified files, and in the MR the files are renamed, some are deleted but still referenced in the libraries...
I'd prefer to use several issues for this to keep it clean and maintainable.

Let's focus on adding a field widget in this issue.
Create another issue for migrating to the new OOP Hooks, one issue for documentation stuff like the README.md and if anything needs a complete refactoring then also another issue for this please.

guido_s’s picture

guido_s
Location Cologne
commented
Status: Needs review » Needs work
guido_s’s picture

guido_s
Location Cologne
commented

I created 2 new issues to handle OOP Hooks and documentation.