Problem/Motivation

ON 10.6.x when you run it on PHP 8.1 you will get a warning on PHP 8.1 - some of tests try to cope with the variation using \Drupal\Tests\RequirementsPageTrait but are doing so incorrectly. See https://git.drupalcode.org/project/drupal/-/pipelines/732843

We will hit this again the moment we start recommending people update to PHP 8.5 on Drupal 11 in order to prepare for Drupal 12

Steps to reproduce

Run PHP 8.1 tests on 10.6.x

Proposed resolution

Fix tests.

Remaining tasks

User interface changes

None

Introduced terminology

N/a

API changes

None

Data model changes

None

Release notes snippet

N/a

Issue fork drupal-3571492

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott opened merge request !14639

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review

Note this issue will need forward porting all the way to main :)

alexpott opened merge request !14641

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

We're green on PHP 7.1 / MySQL 5.7 / 10.6.x and on main with the same fix so I think we're good to go here.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Oh this looks sensible, let's do it.

  • longwave committed d37bfd70 on 11.3.x 
    test: #3571492 Several tests fail on PHP 8.1 on 10.6.x because of...

  • longwave committed dcaea849 on 11.x 
    test: #3571492 Several tests fail on PHP 8.1 on 10.6.x because of...

  • longwave committed a524d016 on main 
    test: #3571492 Several tests fail on PHP 8.1 on 10.6.x because of...

  • longwave committed f739f7aa on 10.6.x 
    test: #3571492 Several tests fail on PHP 8.1 on 10.6.x because of...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed a524d016a9c to main and dcaea8493fc to 11.x and d37bfd70f53 to 11.3.x. Thanks!

Committed and pushed f739f7aa98c to 10.6.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

longwave closed merge request !14639

longwave closed merge request !14641

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.