Problem/Motivation

The css/js query string is used when:

1. Aggregation is disabled site-wide
2. Aggregation is disabled for an individual CSS file
3. Aggregation is disabled for an individual JavaScript file and the library for that file doesn't have a version.

One most sites, none of these will be very common in production, so we can slightly refactor some logic to ensure it's only requested at the point it's actually needed.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3571351

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review

catch opened merge request !14625

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Eye test LGTM. Guess proof is in the pudding with the performance improvements

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

If it wasn't for the performance tests we could backport this down to 11.3.x and 10.6.x. Open to doing that if anyone wants to open a fresh MR? Otherwise, let's just leave this until 11.4.0.

Committed and pushed 3c07b176ed1 to main and 7f0aa96ad4c to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • longwave committed 7f0aa96a on 11.x 
    refactor: #3571351 Only get the css/js query string when necessary

By:...

  • longwave committed 3c07b176 on main 
    refactor: #3571351 Only get the css/js query string when necessary

By:...

longwave closed merge request !14625

catch’s picture

catch
he/him
Primary language English
commented

It's a very small improvement so I think it's fine for it to wait until 11.4.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.