Problem/Motivation

Code style cleanup, tugboat, gitlab CI & basic Tests

Same as last year, James?

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork drowl_admin_dashboard-3571234

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

lrwebks’s picture

lrwebks commented

Same procedure as every year!

lrwebks’s picture

lrwebks commented

Now that I think about it, I will probably do the other issues assigned to me first, so that the "spit-shine" is only applied at the end here.

lrwebks opened merge request !16

lrwebks’s picture

lrwebks commented
Status: Active » Needs work

Unfortunately I cannot fix the whole pipeline here, since Stylelint especially wants to unwrap and modify the minified CSS files for some reason, which is probably unwanted, right? Also, what features should be tested here specifically? I can and will attach the GenericModuleTestBase for premade Drupal installation, settings, etc. tests, but what else?

lrwebks’s picture

lrwebks commented
Status: Needs work » Needs review

A bit messy here right now, which does bother me, but I have wasted enough time here already and don't seem to get any further with this...

lrwebks’s picture

lrwebks commented
Status: Needs review » Needs work

@anybody and I talked about what basic tests to also include here, so I will do that.

lrwebks’s picture

lrwebks commented
Assigned: lrwebks » Unassigned
Status: Needs work » Needs review

I have added the tests as I envision them. Unfortunately I cannot test them locally since the schema errors present in the view configs apparently take higher precedence in PHPUnit. I don't really understand these errors and I fear just deleting the config that causes the errors might break the config that was intended.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » lrwebks
Status: Needs review » Needs work

Tests have phpcs errors

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Regarding the tests it looks like the image module dependency was missing in the .info.yml

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Maybe moving the views to config/optional is good enough. Otherwise we'll need to add 'test_user_config' to $modules.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Okay solved, now the tests seem indeed wrong.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@lrwebks:

Please test:

  1. Generic module install (DONE)
  2. Users with redirect permission are redirected
  3. Users without redirect permission are NOT redirected (regular page after login) - you COULD test that despite having the access dashboard permission, but it's not really needed.
  4. Users with access dashboard permission can see the dashbiard
  5. Users without access dashboard permission get access denied

Current tests seem a bit strange partially, especially the redirect for users without permission to the dashboard don't make much sense to me. Assume that users either have both or none of the permissions logically.

lrwebks’s picture

lrwebks commented
Assigned: lrwebks » Unassigned
Status: Needs work » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

All green, thanks @lrwebks!! :)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.