Problem/Motivation

After #3339905: Add page_top and page_bottom to #attached to get rid of NodeThemeHooks::pageTop() we can attach page_top directly in controller results, removing the need for a route check on every request in BlockHooks::pageTop

Steps to reproduce

N/A

Proposed resolution

Move logic from BlockHooks::pageTop to attachment in BlockController::demo

Remaining tasks

All

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Issue fork drupal-3571143

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

acbramley created an issue. See original summary.

acbramley’s picture

acbramley commented
Related issues: +#3339905: Add page_top and page_bottom to #attached to get rid of NodeThemeHooks::pageTop()
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: [PP-1] Convert BlockHooks::pageTop to attachment in BlockController::demo » Convert BlockHooks::pageTop to attachment in BlockController::demo
Status: Postponed » Active

The linked issue landed.

acbramley opened merge request !14723

acbramley’s picture

acbramley commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Applied the MR and verified that the back button still appears and functions as before.

Not related but did find a new bug too on this page #3573614: Exit block region button hidden when navigation module is installed.

godotislate’s picture

godotislate
he/him
commented
Status: Reviewed & tested by the community » Needs work

One minor comment on the MR.
I'm not seeing any extensions of BlockController in contrib, so I don't think we'll need BC.

acbramley’s picture

acbramley commented
Status: Needs work » Reviewed & tested by the community

Failure looks potentially random but I can't rerun it https://git.drupalcode.org/project/drupal/-/jobs/8838546

godotislate closed merge request !14723

godotislate’s picture

godotislate
he/him
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed to main and 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • godotislate committed f72b6b28 on main 
    refactor: #3571143 Convert BlockHooks::pageTop to attachment in...

  • godotislate committed c3a8de20 on 11.x 
    refactor: #3571143 Convert BlockHooks::pageTop to attachment in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.