Problem/Motivation

Able Player 4.8.0-rc1 is available. It introduces a new poster attribute that we will need to add to the templates and potentially create storage for if a suitable field does not already exist.

CommentFileSizeAuthor
#4 ableplayer-3571113-MR48-4.patch504.09 KBmably

Issue fork ableplayer-3571113

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

themusician created an issue. See original summary.

mably’s picture

mably commented

Able Player 4.8 has been released on February 6:

https://github.com/ableplayer/ableplayer/releases/tag/v4.8.0

It fixes quite a few annoying bugs like this one:

https://github.com/ableplayer/ableplayer/issues/694

Would be interesting to have a release of the module integrating this new version of the Able Player library.

mably opened merge request !48

mably’s picture

mably commented
Status: Active » Needs review
StatusFileSize
new ableplayer-3571113-MR48-4.patch504.09 KB

Patch provided for composer usage.

themusician’s picture

themusician commented

Thank you Mably. In updates to the library I like to grab the minified CSS file they supply as well, often the JS will target a selector that is then styled by that CSS.

Were you able to try out the new feature introduced in 4.8?

Add support for an audio poster image defined by data-poster for the image URL and data-poster-alt for the alternative text.

I think we have to add an image field to the audio field in Able Player. I have been trying to get some of the installation tests to work, no luck, down to 1 failure but I can't seem to figure that out. https://git.drupalcode.org/issue/ableplayer-3574867/-/pipelines/749019/t...

I can try to turn my attention to this update when I am able to focus on the module in the coming weeks. This is a great start on rolling 4.8 into the module. So glad it can fix an issue you are experiencing.

mably’s picture

mably commented

We are using AblePlayer on the https://www.bordeaux.fr web site.

We noticed the controller buttons were quite buggy with YT videos and upgrading to 4.8.0 seemed to fix the problem.

We also add some YT were the controller wasn't displaying at all with 4.7.0, the problem disappeared with 4.8.0.

We have not tested that new audio poster image feature as we only use Able Player for video on our site.

Do you want me to add the new CSS to the MR?

themusician’s picture

themusician commented

If you can add the CSS to the MR, that would be great. Thank you.

mably’s picture

mably commented

It's added.

  • themusician committed 31f77395 on 3.x authored by mably 
    task: #3571113 Able Player 4.8 upstream is available

By: themusician
By...
themusician’s picture

themusician commented
Status: Needs review » Fixed

Thank you @mably. The code is tested locally and working as expected. The dev branch 3.x-dev is now running 4.8. I'll make a new feature issue for adding support for an audio poster image. Let me know how this goes. Contribution credit has been added.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

mably’s picture

mably commented

Thanks @themusician. We have deployed the 4.8 JS on our website https://www.bordeaux.fr. Everything seems to run fine for now.

themusician’s picture

themusician commented

Wonderful. Thank you for the support on getting it to 4.8.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.