Problem/Motivation

#3414627: Convert StreamWrapperManager to use a service locator added a service locator for stream wrappers, but metadata about the stream wrappers was still injected into StreamWrapperManager from a custom compiler pass.

However, that metadata is available from the service locator itself, so we can remove the custom compiler pass entirely.

Steps to reproduce

Proposed resolution

Remove the custom compiler pass.
Refactor the class so stream wrapper metadata is retrieved from the service locator wrapper.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3571094

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review

longwave opened merge request !14599

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

I've read through the changes a few times and can't find anything obviously wrong with it. The only curiosity is that apparently addStreamWrapper() was public, but not in the interface. I don't know if there's some history there that I'm not aware of. Anyway, I didn't find any additional usages of RegisterStreamWrappersPass or StreamWrapperManager::addStreamWrapper(). File uploads continued to work on my local after applying the MR, as I expected. I think this is good to go.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

I search contrib and could find not released modules using addStreamWrapper in runtime code and the rest of this is very much internals so I think this is fine to change in a minor release.

Committed and pushed a4cda8572f3 to main and 1ee7cb4efe5 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • alexpott committed 1ee7cb4e on 11.x 
    task: #3571094 Remove RegisterStreamWrappersPass

By: longwave
(cherry...

  • alexpott committed a4cda857 on main 
    task: #3571094 Remove RegisterStreamWrappersPass

By: longwave

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

godotislate closed merge request !14599