Please don't pick up multiple ones, want to give everyone a chance

Problem/Motivation

Remove all D12 deprecated code from the mentioned libraries.

Steps to reproduce

Proposed resolution

Remove all D12 deprecated code from the mentioned libraries.

Remaining tasks

Make sure tests are passing before review.

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3571066

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

smustgrave’s picture

smustgrave commented

#3571063: Remove Deprecated methods in ModuleHandler and ModuleHandlerInterface slated for removal in 12 overlaps with this so ignore those.

longwave made their first commit to this issue’s fork.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review

longwave opened merge request !14624

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work
nicxvan’s picture

nicxvan commented
Related issues: +#3571067: [12.x] Remove hook_hook_info and support in HookCollectorPass

Please don't change anything in module handler, hookcollectorpass or related tests that is related to hook hook info and is more complex than it seems.

Edit: unfortunately there is quite a bit of overlap. There is some hidden complexity with the hook hook info and hook module implements alter removals so I'd like to take care of those.

nicxvan’s picture

nicxvan commented

The hook_hook_info removal is ready for review.

nicxvan’s picture

nicxvan commented
Related issues: +#3571069: Remove hook_module_implements_alter and support in HookCollectorPass

For completeness, attaching the hook_module_implements_alter issue.

nicxvan’s picture

nicxvan commented
Title: Remove deprecated code from lib/Extension » Remove deprecated code from lib/Extension except relating to hook_hook_info or hook_module_implements_alter
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review

Reverted the ModuleHandler changes.

nicxvan’s picture

nicxvan commented
Status: Needs review » Needs work

The baseline needs to be updated I think.

smustgrave’s picture

smustgrave commented

Does this one just need a rebase?

nicxvan’s picture

nicxvan commented
Status: Needs work » Closed (outdated)

These have all been removed elsewhere as far as I can see.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.