Please don't pick up multiple ones, want to give everyone a chance

Problem/Motivation

Remove all D12 deprecated code from the mentioned libraries.

Steps to reproduce

Proposed resolution

Remove all D12 deprecated code from the mentioned libraries.

Remaining tasks

Make sure tests are passing before review.

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3571065

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

miroslavstankov made their first commit to this issue’s fork.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

@miroslavstankov: I see you started a merge request. This is possibly not a trivial one with the origin stuff and so on, please add a note whether or not you plan to work on this. You can also reach out if you have questions.

miroslavstankov’s picture

miroslavstankov commented

Sorry, I accidentally created the issue fork while looking into this issue. I’m currently working on another issue, but once I’m done I can take a look here as well.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

No worries, I just wanted to make sure that I'm not duplicating your work.

Assign it to you if you work on it, I might do the same

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Assigned: Unassigned » berdir

berdir opened merge request !14660

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Assigned: berdir » Unassigned
Status: Active » Needs review

Couldn't resist doing this myself. There's actually not that much, Mostly ->original related and a bunch of one-off things.

dww’s picture

dww
we/he/they
commented
Status: Needs review » Needs work

Thanks for working on thiss.
Pipeline failures (not random).

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Reviewed & tested by the community

This is green now.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Needs review

Oops, I just meant to set it to needs review.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Appears to be 1 more instances in EntityRepository and 1 in BaseFieldDefinition

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review

Nice catch, removed those now as well.

smustgrave’s picture

smustgrave commented

Don’t mind marking mind fixing the phpcs real quick please

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

LGTM

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

One comment on the MR - looks like we can remove a bit more.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review

Removed that test class.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Additional removal looks good

  • catch committed c11e445f on main 
    task: #3571065 Remove deprecated code from lib/Entity and lib/Field

By...

catch closed merge request !14660

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.