Problem/Motivation

12 is open, let's remove methods deprecated for removal in 12.

Steps to reproduce

N/A

Proposed resolution

Remove the 6 deprecated methods in modulehandler
Remove tests for them
Remove phpstan baseline rules
Update hook collector pass to related to the deprecated methods

Remaining tasks

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Issue fork drupal-3571063

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nicxvan created an issue. See original summary.

nicxvan’s picture

nicxvan commented
Title: Remove Deprecated methods in ModuleHandler and ModuleHandlerInterface » Remove Deprecated methods in ModuleHandler and ModuleHandlerInterface slated for removal in 12
nicxvan’s picture

nicxvan commented
Assigned: Unassigned » nicxvan

nicxvan opened merge request !14595

nicxvan’s picture

nicxvan commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented

Seems to be 1 more call in getHookImplementationList() that in scope here?

nicxvan’s picture

nicxvan commented

Thanks for checking!

If you mean:

foreach ($this->hookGroupIncludes[$hook] ?? [] as $include) {
          @trigger_error('Autoloading hooks in the file (' . $include . ') is deprecated in drupal:11.2.0 and is removed from drupal:12.0.0. Move the functions in this file to either the .module file or other appropriate location. See https://www.drupal.org/node/3489765', E_USER_DEPRECATED);
          include_once $include;
        }

That will be addressed in: #3571067: [12.x] Remove hook_hook_info and support in HookCollectorPass which is postponed on this issue.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

in that case that was the only remaining deprecation. LGTM

nicxvan’s picture

nicxvan commented
Issue summary: View changes
nicxvan’s picture

nicxvan commented
Assigned: nicxvan » Unassigned
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !14595

  • catch committed b2c257c4 on main 
    task: #3571063 Remove Deprecated methods in ModuleHandler and...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.