Closed (fixed)
Project:
Drupal core
Version:
main
Component:
other
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
1 Feb 2026 at 05:40 UTC
Updated:
21 Apr 2026 at 14:30 UTC
Jump to comment: Most recent
As per #3404246: [META] Fix strict type errors detected by phpstan
We've fixed quite a few issues in the meta, and there are a few more ready to go, but there are still a few hundred violations. This issue is to eventually add the parameter and commit the baseline, when we're comfortable.
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
mondrakeon this
Comment #4
mondrakeComment #5
mstrelan commentedI think it needs a rebase. I generated the baseline from main then compared with this branch and found one additional entry that I think is no longer required since #3555534: Since symfony/validator 7.4: Support for evaluating options in the base Constraint class is deprecated. Initialize properties in the constructor instead.
Comment #6
mondrakeRebased - this will need frequent reroll.
Comment #8
smustgrave commentedIf it helps capture stuff in the future all for it.
Comment #9
smustgrave commentedThink I jumped the gun
Comment #10
smustgrave commentedAppears to need a rebase but is this ready to merge or does the parent need to land?
Comment #11
mstrelan commentedLet's finish up #3561385: Fix "expects FieldableEntityInterface" issues detected by phpstan then reroll this. Can see then if we want to work on more fixes before committing the baseline.
Comment #12
mstrelan commentedRerolled this. It was 446 errors when mondrake first submitted the MR. It's now down to 223, although some of them have multiple counts in the same file, so I'm not sure whether those were originally counted.
Comment #13
smustgrave commentedSorry for taking me a while to get to. @mstrelan mind rebasing one more time. If you ping me I'll review
Comment #14
mondrakerebased
Comment #15
smustgrave commentedThanks! Always bummer to see the baseline go up so much but gives people something to work on!
Comment #16
mondrakeNeeds rebasing again...
Comment #17
mondrakeComment #18
mstrelan commentedMerged in main as there were existing merge commits and regenerated the baseline. Setting back to RTBC.
Comment #21
godotislateNot sure this needs to go into 11.x, but even if it did, it'd need a separate MR. Moving this to fixed, but if someone feels strongly about 11.x and opens a new MR, can reopen.
Committed c6a388b and pushed to main. Thanks!