See CI results for the latest warining
phpcs
FILE: src/Form/WebformJiraConfigurationForm.php
---------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------
362 | ERROR | Description for the @return value is missing (Drupal.Commenting.FunctionComment.MissingReturnComment)
phpstan
Line src/Form/JiraServiceDeskConfigurationForm.php
------ ----------------------------------------------------------------------
60 Method Drupal\Core\Form\ConfigFormBase::__construct() invoked with 1
parameter, 2 required.
🪪 arguments.count
------ ----------------------------------------------------------------------
------ ----------------------------------------------------------------------
Line src/Form/WebformJiraConfigurationForm.php
------ ----------------------------------------------------------------------
324 \Drupal calls should be avoided in classes, use dependency injection
instead
🪪 globalDrupalDependencyInjection.useDependencyInjection
339 \Drupal calls should be avoided in classes, use dependency injection
instead
🪪 globalDrupalDependencyInjection.useDependencyInjection
365 \Drupal calls should be avoided in classes, use dependency injection
instead
🪪 globalDrupalDependencyInjection.useDependencyInjection
------ ----------------------------------------------------------------------
------ -----------------------------------------------------------------------
Line src/Form/WebformJiraFieldForm.php
------ -----------------------------------------------------------------------
227 Method
Drupal\webform_jira_service_desk\Form\WebformJiraFieldForm::save()
should return int but return statement is missing.
🪪 return.missing
243 \Drupal calls should be avoided in classes, use dependency injection
instead
🪪 globalDrupalDependencyInjection.useDependencyInjection
339 Method
Drupal\webform_jira_service_desk\Form\WebformJiraFieldForm::getJiraTy
pe() should return string but return statement is missing.
🪪 return.missing
------ -----------------------------------------------------------------------
------ -----------------------------------------------------------------------
Line src/JiraServiceDeskService.php
------ -----------------------------------------------------------------------
132 Method
Drupal\webform_jira_service_desk\JiraServiceDeskService::getAvailable
ServiceDesks() should return array but return statement is missing.
🪪 return.missing
162 Method
Drupal\webform_jira_service_desk\JiraServiceDeskService::getAvailable
RequestTypes() should return array but return statement is missing.
🪪 return.missing
------ -----------------------------------------------------------------------
------ ----------------------------------------------------------------------
Line src/Plugin/QueueWorker/SendJiraRequest.php
------ ----------------------------------------------------------------------
94 \Drupal calls should be avoided in classes, use dependency injection
instead
🪪 globalDrupalDependencyInjection.useDependencyInjection
------ ----------------------------------------------------------------------
Comments
Comment #4
jannakha commentedAll green.
Comment #5
vladimirausLooks good. All CI runners are green.
Good to merge and release.
Thanks you for your contribution.
RTBC
Comment #6
jannakha commentedFixed. Releasing...