See CI results for the latest warining

phpcs

FILE: src/Form/WebformJiraConfigurationForm.php
---------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------
 362 | ERROR | Description for the @return value is missing (Drupal.Commenting.FunctionComment.MissingReturnComment)

phpstan

  Line   src/Form/JiraServiceDeskConfigurationForm.php                         
 ------ ---------------------------------------------------------------------- 
  60     Method Drupal\Core\Form\ConfigFormBase::__construct() invoked with 1  
         parameter, 2 required.                                                
         🪪  arguments.count                                                   
 ------ ---------------------------------------------------------------------- 
 ------ ---------------------------------------------------------------------- 
  Line   src/Form/WebformJiraConfigurationForm.php                             
 ------ ---------------------------------------------------------------------- 
  324    \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
         🪪  globalDrupalDependencyInjection.useDependencyInjection            
  339    \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
         🪪  globalDrupalDependencyInjection.useDependencyInjection            
  365    \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
         🪪  globalDrupalDependencyInjection.useDependencyInjection            
 ------ ---------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------- 
  Line   src/Form/WebformJiraFieldForm.php                                      
 ------ ----------------------------------------------------------------------- 
  227    Method                                                                 
         Drupal\webform_jira_service_desk\Form\WebformJiraFieldForm::save()     
         should return int but return statement is missing.                     
         🪪  return.missing                                                     
  243    \Drupal calls should be avoided in classes, use dependency injection   
         instead                                                                
         🪪  globalDrupalDependencyInjection.useDependencyInjection             
  339    Method                                                                 
         Drupal\webform_jira_service_desk\Form\WebformJiraFieldForm::getJiraTy  
         pe() should return string but return statement is missing.             
         🪪  return.missing                                                     
 ------ ----------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------- 
  Line   src/JiraServiceDeskService.php                                         
 ------ ----------------------------------------------------------------------- 
  132    Method                                                                 
         Drupal\webform_jira_service_desk\JiraServiceDeskService::getAvailable  
         ServiceDesks() should return array but return statement is missing.    
         🪪  return.missing                                                     
  162    Method                                                                 
         Drupal\webform_jira_service_desk\JiraServiceDeskService::getAvailable  
         RequestTypes() should return array but return statement is missing.    
         🪪  return.missing                                                     
 ------ ----------------------------------------------------------------------- 
 ------ ---------------------------------------------------------------------- 
  Line   src/Plugin/QueueWorker/SendJiraRequest.php                            
 ------ ---------------------------------------------------------------------- 
  94     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
         🪪  globalDrupalDependencyInjection.useDependencyInjection            
 ------ ---------------------------------------------------------------------- 
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jannakha created an issue. See original summary.

vladimiraus made their first commit to this issue’s fork.

jannakha’s picture

Status: Active » Needs review

All green.

vladimiraus’s picture

Status: Needs review » Reviewed & tested by the community

Looks good. All CI runners are green.
Good to merge and release.
Thanks you for your contribution.
RTBC

jannakha’s picture

Status: Reviewed & tested by the community » Fixed

Fixed. Releasing...

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.