Problem/Motivation

Currently, GD library will put a warning on the Status report if an image file format, such as AVIF, is not supported by the PHP installed on the system. I don't think this should be a warning. There is no need to support AVIF if the site has no need for it.

This check was added in commit 00d6bd9 for #3116611: Add a requirements check for GD support of allowed image types.

Proposed resolution

Use a different RequirementSeverity value so that the message appears with other status messages.

Remaining tasks

Screenshot report before and after

User interface changes

The GD library message appears with other status messages instead of as a warning.

Introduced terminology

None.

API changes

None.

Data model changes

None.

Release notes snippet

Issue fork drupal-3570466

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

liam morland created an issue. See original summary.

liam morland’s picture

Status: Active » Needs review

This merge request makes the GD library message a regular status message.

nicxvan’s picture

Issue summary: View changes
Status: Needs review » Needs work

I think this is a good idea! Just a couple of questions.

Do you have before and after screenshots?

Also shouldn't it be RequirementSeverity::Info?

Finally, while I agree with you, do we need @heddn to comment as the image maintainer?

Maybe we can ask in slack. I'm not tagging for subsystem maintainer review because I'm not sure.

sivaji_ganesh_jojodae’s picture

StatusFileSize
new335.87 KB

See the before and after screenshot added below.

image

liam morland’s picture

Status: Needs work » Needs review

@sivaji_ganesh_jojodae thanks for the screenshots.

I didn't set RequirementSeverity::Info because I made it match the other code already there. If it is supposed to have that, I'm not oppose to adding it.

smustgrave’s picture

Status: Needs review » Needs work
Issue tags: +Needs subsystem maintainer review

Can we update the summary to show the git history where this was added and see if there was discussion around it. Probably needs submaintainer sign off before removing.

liam morland’s picture

mstrelan’s picture

Ideally we could check if there are any image styles using the unsupported format to determine the severity, but that might be a bit too much overhead. Otherwise I guess this makes sense, especially since the existing message makes it sound optional, "if you want to add support".

jrochate’s picture

Works great on Drupal 11.4.1 and it's a logical fix. This warning doesn't deserve so much attention unless image style audit referred by @mstrelan exists and is positive. Thank you.

liam morland’s picture

Status: Needs work » Needs review
liam morland’s picture

Issue summary: View changes

Screenshot is available in comment #5. Thanks

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Per sign off in #9

  • catch committed 016fd084 on 11.x
    task: #3570466 Reduce severity of GD library supported image file...

  • catch committed b6aadece on main
    task: #3570466 Reduce severity of GD library supported image file...
catch’s picture

Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Makes sense to me too, it's something that can be improved rather than a real problem.

Committed/pushed to main and cherry-picked to 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.