Problem/Motivation

PHP 8.4 deprecated implicitly nullable parameters. These have been addressed in http_client_manager 11.x but the Fatal-Error/guzzle-description-loader dependency still has them present in each loader. Update the implicit definitions to be explicitly nullable.

A PR has been created in GitHub: https://github.com/Fatal-Error/guzzle-description-loader/pull/3

Steps to reproduce

- Open each loader in the repo
- Note implicitly null parameters, ie `string $type = null`

Proposed resolution

- Update the definitions to be explicit, ie `?string $type = null`

Comments

cchiste created an issue. See original summary.

aronne’s picture

aronne commented
Status: Needs review » Reviewed & tested by the community

Hi @cchiste and thanks for your contribution.
The pull request has been merged on my repo.

Have a great day

aronne’s picture

aronne commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

cchiste’s picture

cchiste commented
Status: Fixed » Needs work

Good day @aronne!

Apologies for bugging you again.
As http_client_manager requires ^3.1.1 of your repo, when you have a minute could we cut a release or port the changes to 3.x-dev?
With the ^3.1.1 requirement, dev-master is untargetable.

I appreciate all your effort here, thank you!

aronne’s picture

aronne commented

Hi @cchiste,
I've both updated 3.x branch and created a new tag 3.1.2

Let me know if it works correctly now.

Have a great day.

trickfun’s picture

trickfun commented

I have this deprecation to

Deprecated function: Guzzle\Service\Loader\FileLoader::load(): Implicitly marking parameter $type as nullable is deprecated, the explicit nullable type must be used instead in include() (line 576 of /var/www/html/vendor/composer/ClassLoader.php)
cchiste’s picture

cchiste commented
Status: Needs work » Fixed

@trickfun

It looks like you might be on an older version of http_client_manager that is still using the now abandoned arthurkirkosa/guzzle-description-loader package. You will want to get on an updated version or apply the patch in this issue first: https://www.drupal.org/project/http_client_manager/issues/3406108

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.