Problem/Motivation

Running Poll on a Drupal site using PHP 8.4 throws sever deprecated code notices:

Deprecated: Drupal\poll\PollStorage::cancelVote(): Implicitly marking parameter $account as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/code/modules/contrib/poll/src/PollStorage.php on line 54

Deprecated:  Drupal\poll\PollStorageInterface::cancelVote(): Implicitly marking parameter $account as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/code/modules/contrib/poll/src/PollStorageInterface.php on line 40

Steps to reproduce

Install Poll 1.6 on a Drupal site running PHP 8.4. Run a CLI command like drush cr to see deprecations.

Issue fork poll-3570386

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dhansen created an issue. See original summary.

dhansen opened merge request !84

dhansen’s picture

dhansen commented
Status: Active » Needs review
bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented

Thanks for the merge request @dhansen. This also needs to be checked on the 2.x branch

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs review » Needs work
ivnish’s picture

ivnish
he/him
commented
Version: 8.x-1.x-dev » 2.0.x-dev
ivnish’s picture

ivnish
he/him
commented
Status: Needs work » Closed (won't fix)

I checked it. Already fixed in 2.0.x-dev

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

ivnish closed merge request !84