Closed (fixed)
Project:
Drupal core
Version:
11.x-dev
Component:
syslog.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
29 Jan 2026 at 03:09 UTC
Updated:
23 Jul 2026 at 15:41 UTC
Jump to comment: Most recent
Comments
Comment #3
nicxvan commentedComment #4
nicxvan commentedComment #5
mstrelan commentedAdded two suggestions
Comment #6
nicxvan commentedComment #7
dcam commentedI was looking into the question of what to do about the contrib usage of
syslog_facility_list(). I'm not seeing the usage in logger or extended_logger. They both have similarly-named class methods that came up in the search results. In fact logger has two identical methods duplicated in two forms. But I cloned both modules and grepped them just to be certain thatsyslog_facility_listisn't used. I didn't find anything. You might double-check your own results. We may not need to worry about this.Comment #8
dcam commentedThat same docblock references a function that doesn't exist anymore. I left a suggestion to fix it.
Comment #9
nicxvan commentedYou're right, I just double checked.
Needs work for updating the IS and your comment on documentation.
There is also an open question about deprecation versions.
Comment #10
nicxvan commentedComment #11
nicxvan commentedI also applied your suggestion and updated the issue summary.
Comment #12
dcam commentedMy feedback was addressed. This looks good to me.
Comment #13
longwaveAdded a question.
Comment #14
nicxvan commentedI converted it to a config_target, good suggestion!
Comment #15
dcam commentedIt was a good suggestion. It's always nice to simplify code.
I did a manual test of the form after applying the latest changes. The config targets work properly. The
syslog.settingsconfiguration continues to be updated by the form. The deprecation notice for the former submit function has been updated to note that it is now deprecated without replacement. This looks good.Comment #16
longwaveconfig_target should set default_value automatically, which means we can drop even more code!
Comment #17
nicxvan commentedOh I didn't know that!
That will be a nice cleanup.
Comment #18
nicxvan commentedComment #19
nicxvan commentedComment #20
dcam commentedI forgot all about it too. I don't write enough forms these days.
All of the
#default_valuekeys have been removed and the config is no longer loaded by the form, simplifying it even further. I did another manual test of the form and it continued to update the config values correctly. LGTM.Comment #21
longwaveCommitted and pushed 4dcc7892403 to main and ad10a2e50e0 to 11.x. Thanks!