Problem/Motivation

This was initially in #2910353: Prevent saving config entities when configuration overrides are applied.
RoleSettingsForm::submitForm() loads config with overrides and then saves it, this will save the overrides in the database.

Steps to reproduce

Proposed resolution

Use loadMultipleOverrideFree() to load config entities.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3570220

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

prudloff created an issue. See original summary.

prudloff opened merge request !14541

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review

I don't think this requires a test. The config is being loaded and saved in the same method. This will get implicit test coverage when we deprecate saving config entities with overrides applied.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Same here as in #3570219: BlockListBuilder::submitForm() should not load config overrides, the change is simple and is confirmed to work and fix the problem through the existing MR on the meta issue that we've been using for years.

nicxvan’s picture

nicxvan commented
Status: Needs review » Reviewed & tested by the community

Looks good, there was a discussion on slack confirming these issues can be solved without a test.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: main » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed f5b6540a865 to main and 51778d1dcde to 11.x and 14a3a22f95b to 11.3.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • alexpott committed 14a3a22f on 11.3.x 
    fix: #3570220 RoleSettingsForm::submitForm() should not load config...

  • alexpott committed 51778d1d on 11.x 
    fix: #3570220 RoleSettingsForm::submitForm() should not load config...

  • alexpott committed f5b6540a on main 
    fix: #3570220 RoleSettingsForm::submitForm() should not load config...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.