Problem/Motivation

Discovered in #3570077: Update to Symfony 8

Symfony\Component\Console\Command\Command::configure() has a return type added in Symfony 8, not sure why this wasn't detected earlier via DebugClassLoader (the docblock was present in Symfony 7) but we can fix it in Drupal 11.

Steps to reproduce

Proposed resolution

Add void return type to Command::configure() implementations.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3570141

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review

longwave opened merge request !14532

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Reviewed & tested by the community

Seems straightforward to me.

  • catch committed 342b1df1 on 11.x 
    task: #3570141 Add void return type to Symfony Console ::configure()...

  • catch committed 2d6cc5ff on main 
    task: #3570141 Add void return type to Symfony Console ::configure()...
catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !14532

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.