Problem/Motivation

The goal of this ticket is to apply in the version 5.1.x the same solution of #3559547: YouTube video keeps playing after closing modal

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#12 3570102.patch1.91 KBrenatog
#9 sc-after-MR.mp46.35 MBangel_devoeted

Issue fork modal_page-3570102

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

renatog created an issue. See original summary.

renatog’s picture

renatog commented
Parent issue: » #3559547: YouTube video keeps playing after closing modal
dhruv.mittal’s picture

dhruv.mittal commented
Assigned: Unassigned » dhruv.mittal

Working on it

dhruv.mittal opened merge request !69

dhruv.mittal’s picture

dhruv.mittal commented
Assigned: dhruv.mittal » Unassigned
Status: Active » Needs review
angel_devoeted’s picture

angel_devoeted commented
Status: Needs review » Needs work

The 3570102-5.1.x-youtube-video currently fatals with:
Fatal error: Cannot redeclare modal_page_modules_installed().
The function is declared twice in modal_page.module (lines 316 and 333).
This needs to be resolved before further review/testing.

renatog’s picture

renatog commented

Thanks for catching that @angel_devoeted

dhruv.mittal’s picture

dhruv.mittal commented
Status: Needs work » Needs review

Please review now

angel_devoeted’s picture

angel_devoeted commented
StatusFileSize
new sc-after-MR.mp46.35 MB

Re-tested with the latest changes and it works as expected now.
The YouTube video stops when the modal is closed.

Attached a short screen capture showing the behavior.

renatog’s picture

renatog commented
Status: Needs review » Reviewed & tested by the community

Based on #9, moving that to RTBC

renatog’s picture

renatog commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Novice

MR can not be merged yet

Has multiple changes that is not related to this YouTube fix

We need to get this commit and apply the same updates on branch 5.1.x

renatog’s picture

renatog commented
Status: Needs work » Needs review
Issue tags: -Novice
StatusFileSize
new 3570102.patch1.91 KB

Patch attached for 5.1.x

  • 308da6c9 committed on 5.1.x 
    feat: #3570102 [5.1.x] YouTube video keeps playing after closing modal...
renatog’s picture

renatog commented
Status: Needs review » Fixed

Moved to the dev branch

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

renatog’s picture

renatog commented

Released the new version with this fix

https://www.drupal.org/project/modal_page/releases/5.1.10

Thank you so much for your awesome contribution @dhruvmittal, @keszthelyi and @angel_devoeted

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.