Problem/Motivation

In the TimeRangeWidgetBase->formElement(), almost all code is duplicated from the parent DateRangeWidgetBase

Proposed resolution

Remove duplicated code and keep only code which realy needs

Issue fork time_range-3570085

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

vitaliyb98 created an issue. See original summary.

vitaliyb98 opened merge request !4

vitaliyb98’s picture

vitaliyb98 commented
Status: Active » Needs review

Removed code that was already introduced in the parent class.

vitaliyb98’s picture

vitaliyb98 commented
Assigned: vitaliyb98 » Unassigned
vitaliyb98’s picture

vitaliyb98 commented

It would be great if someone could review this as well.

vitaliyb98’s picture

vitaliyb98 commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • 2c5acb1c committed on 9.0.x 
    feat: #3570085 Removed duplicated code in formElement.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.