Problem/Motivation

#3559481: Let ImageToolkit and ImageToolkitOperations plugins be container aware and autowireable added readonly properties to toolkit but unfortunately this broke PHP 8.3 due to readonly properties and setting the services in \Drupal\Core\DependencyInjection\DependencySerializationTrait::__wakeup()

Steps to reproduce

Run \Drupal\FunctionalTests\Image\ToolkitSetupFormTest::testToolkitSetupForm on PHP 8.3 - https://issue.pages.drupalcode.org/-/drupal-3564689/-/jobs/8238108/artif...

Proposed resolution

I tried out the reflection idea on #3424344: Allow DependencySerializationTrait to work with readonly properties but it did not work. So removing seems the best idea. We can leave in main as #3537713: [12.x] Require PHP 8.5 will happen soon.

Remaining tasks

User interface changes

None

Introduced terminology

N/a

API changes

Less readonly

Data model changes

None

Release notes snippet

N/a

Issue fork drupal-3569870

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

alexpott created an issue. See original summary.

longwave’s picture

Status: Active » Reviewed & tested by the community

  • catch committed 6ce40dba on 11.x
    fix: #3569870 Remove readonly properties from image toolkits
    
    By:...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.