Update to latest version v0.0.7 of vitrus/symfony-office-graph-mailer, to support reply-to.

https://github.com/vitrus/symfony-office-graph-mailer

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

matthiasm11 created an issue. See original summary.

aayush7 made their first commit to this issue’s fork.

aayushpathak’s picture

working on it !

aayushpathak’s picture

Updated composer.json to allow vitrus/symfony-office-graph-mailer ^0.0.7, enabling Reply-To support added upstream.
Composer update tested in a full Drupal project context.

aayushpathak’s picture

Status: Active » Needs review
drubb’s picture

Status: Needs review » Needs work

Hey, Aayush,

Thanks for your contribution. Just one minor thing:

It makes sense to limit automatic updates to minor versions. So if we're changing the version constraint from '0.0.7' to a bigger range, imho this should be '~0.0.7', not '^0.0.7', that's too broad. Please update your MR accordingly.

If you'd like to work on it, there's the same issue for another project, Symfony Mailer GraphAPI:

https://www.drupal.org/project/symfony_mailer_graphapi/issues/3569807

Best regards,
Boris

drubb’s picture

Sorry, I've got it wrong; we're dealing with unstable versions here (< 1.0.0). That means '^0.0.7' is practically the same as '0.0.7', it won't allow updates to e.g. '0.0.8'. My conclusion, however, is the same: using '~0.0.7' to allow minor updates.

aayushpathak’s picture

Status: Needs work » Needs review

Thanks for the clarification,

I’ve updated the dependency constraint to ~0.0.7 to allow minor updates for unstable releases and pushed the corrected composer.json.

Please let me know if anything else needs adjustment.

  • drubb committed 8d6741ff on 1.0.x authored by aayush7
    #3569809: Update Vitrus/symfony-office-graph-mailer.
    
drubb’s picture

Status: Needs review » Fixed

Merged to dev.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.