Problem/Motivation

On RoleStorage.php, the documentation comment for the class is the following one.

/**
 * Controller class for user roles.
 */

The class is not a controller class; it is a storage class.

Proposed resolution

Change the short description to Defines the storage handler class for user roles. which is similar to the short description used in NodeStorage.php (Defines the storage handler class for nodes.)

Issue fork drupal-3569752

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

avpaderno created an issue. See original summary.

avpaderno opened merge request !14508

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Seems straight forward and agree not a controller.

catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed d7801a1a on main 
    docs: #3569752 RoleStorage is described as controller class

By:...

catch closed merge request !14508

  • catch committed 0b3f4b60 on 11.x 
    docs: #3569752 RoleStorage is described as controller class

By:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.