Problem/Motivation

Expose

  • min_delivery_period_fallback
  • max_delivery_period_fallback

from https://git.drupalcode.org/project/commerce_product_availability/-/blob/...

as tokens to be used in customer information texts, e.g. shipping page

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork commerce_product_availability-3569563

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

grevil made their first commit to this issue’s fork.

grevil’s picture

grevil commented
Assigned: anybody » Unassigned
Status: Active » Needs review

Done, please review!

Already manually tested.

anybody opened merge request !31

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Nice! Just added a little "default" info to the description, because fallback is very technically.

Would be great to have some tests to ensure it works as expected, but LGTM!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Needs work

@grevil back to NW:

 ------ ---------------------------------------------------------------------- 
  Line   src/Hook/CommerceProductAvailabilityTokenHooks.php                    
 ------ ---------------------------------------------------------------------- 
  49     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
         🪪  globalDrupalDependencyInjection.useDependencyInjection            
 ------ ----------------------------------------------------------------------

Then also try adding tests if simple. And afterwards ping me, then I'll integrate it :)

grevil’s picture

grevil commented
Status: Needs work » Reviewed & tested by the community

Done.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

GREAT!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Title: Expose as tokens » Expose fallback / default delivery period values as tokens

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.