Problem/Motivation

Part of #3399840: [meta] Replace http urls with https urls of the respective sites in core
Unless specifically testing the 'http' protocol https should be used for URLs.

Steps to reproduce

git grep http://jsonapi.org

Proposed resolution

Change 'http' to 'https' for 'jsonapi.org'

Remaining tasks

Changes should be made with a script. Something like
git grep -l http://test.com | xargs sed -i 's#http://test.com#https://test.com#g'. Post the commands used.
Run core/scripts/dev/commit-code-check.sh locally
Create MR

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3569458

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

quietone created an issue. See original summary.

sujal kshatri made their first commit to this issue’s fork.

sujal kshatri’s picture

Status: Active » Needs review

Replaced http://jsonapi.org URLs with https://jsonapi.org

Changes were made using the following command:
git grep -l http://jsonapi.org | xargs sed -i 's#http://jsonapi.org#https://jsonapi.org#g'

After applying the changes, i typed this command:
git grep http://jsonapi.org
which returned no results.

after which i ran core/scripts/dev/commit-code-check.sh locally.

dcam made their first commit to this issue’s fork.

dcam’s picture

Status: Needs review » Reviewed & tested by the community

I had to rebase it in order to be able to pull the MR to my local.

I opened all of the edited URLs. They all work correctly. I searched Core for jsonapi.org and checked all of the instances. They all have the https:// scheme.

I also validated all of the changes. When replacements are done via script like this it's possible for incorrect changes to creep in, even if it seems pretty cut-and-dry (See #3569457-8: Replace http with https for test.com and www.test.com for an example). But these are all appropriate. All but three of the changes are in comments and harmless.

This looks good to me.

stefan lehmann’s picture

I came to the same result as dcam. The only link I found not working is:

https://jsonapi.org/schemas/spec/v1.1/draft in core/modules/jsonapi/src/JsonApiSpec.php in Line 28:

const SUPPORTED_SPECIFICATION_PERMALINK = 'https://jsonapi.org/format/1.1/';

However that link didn't work before the change either. I'm a bit confused where the schema for 1.1 actually lives. The only schemas I could find are these ones here:
https://github.com/json-api/json-api/tree/gh-pages/_schemas

.. but there is no 1.1 version nor is there a link on jsonapi.org as far as I can see.

Leaving this on Reviewed & tested by the community as this seems to be unrelated.

Yeah that bit of code is actually not even touched by the current MR.

longwave’s picture

Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 1d23af4cea6 to main and 6244f187837 to 11.x. Thanks!

Given this is mostly documentation not sure it's worth trying to backport further.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • longwave committed 6244f187 on 11.x
    fix: #3569458 Replace http with https for jsonapi.org
    
    By: quietone
    By:...

  • longwave committed 1d23af4c on main
    fix: #3569458 Replace http with https for jsonapi.org
    
    By: quietone
    By:...
thirteenthdown’s picture

Status: Fixed » Closed (fixed)

I checked the 11.x codebase to work on this, but it looks like all 38 instances of jsonapi.org are already using the https:// protocol! This was likely resolved by another commit in the overarching meta issue. Closing this as fixed/outdated.

quietone’s picture

Status: Closed (fixed) » Fixed

The correct status for this issue should be Fixed.

@thirteenthdown, Welcome to Drupal! Please read my comment on another issue you have commented on.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.