Replace http with https for test.com and www.test.com

replaced http://test.com and http://www.test.com with their https equivalents.

Changes were made using the following commands:

git grep -l http://test.com | xargs sed -i 's#http://test.com#https://test.com#g'
git grep -l http://www.test.com | xargs sed -i 's#http://www.test.com#https://www.test.com#g'

After applying the changes, running:

git grep http://test.com
git grep http://www.test.com

returned no results.

testUrlFilterContent is getting failed

Filter Kernel (Drupal\Tests\filter\Kernel\FilterKernel)
✔ Align filter
✔ Caption filter
✔ Align and caption filters
✔ Line break filter
✔ Line break filter twig debug
✔ Html filter
✔ No follow filter
✔ Html escape filter
✔ Url filter
✘ Url filter content

i am not able to understand why this test is failing,
i need some guidance as to how to fix this

The problem is in core/modules/filter/tests/filter.url-output.txt. This file represents what a block of text should look like after the filter module has acted on it. One of the applied filters turns URLs that are written in the text into anchor links. If a URL does not have a scheme (http:// or https://), then it will prepend "http://" to its URL in the anchor. You replaced all of these with https://, so the expected text no longer matches.

Thanks for explaining, which means I should only fix the test output by changing the https:// links back to http:// in filter.url-output.txt?
Does filter.url-input.txt file also need a change?

...which means I should only fix the test output by changing the https:// links back to http:// in filter.url-output.txt?

Correct.

Oh, so that was where i was going wrong
I'll make the changes

I did it manually for filter.url-output.txt, no grep commands were used so if any of http still get left that needs a change then do let me know

Also there is a line in filter.url-output.txt

The old URL filter has problems with <a title="kind of link www.example.com with text" href="https://www.example.com">this kind of link</a> with www address as part of text in title.

earlier here it was http , i changed it to https , did i do the right thing ?

The old URL filter has problems with <a title="kind of link www.example.com with text" href="https://www.example.com">this kind of link</a> with www address as part of text in title.

i think here i should have kept it as http only because there's it doesn't have a protocol in the link text

Finally the pipeline passed!!

Thank you for your hard work, @sujal kshatri.

I searched core for any additional references to http:\/\/(www\.)?test\.com. I believe I found four more that need to be changed. I left suggestions for them in the MR. I'm setting the status to Needs Work for you to consider them.

Thank you so much for the review
Initially I did change them , but these were the reason the Filter Kernel was failing again and again , and also @quietone told to only change which have a protocol in link text, so i had to revert back, these 4 were the one i had doubt in.

The error was something like:-

✘ Url filter content
       ┐
       ├ Complex HTML document was correctly processed.  
       ├ Failed asserting that two strings are identical.
       ┊ ---·Expected
       ┊ +++·Actual
       ┊ @@ @@
       ┊ -Testing·code·tag·http://www.test.com·abc
       ┊ +Testing·code·tag·https://www.test.com·abc
       ┊

Just let me know if i should change these four as well, I'll happily make the changes ,I just want a final confirmation ,

I interpret @quietone's comment a little differently. URLs that aren't enclosed in anchor tags should still be changed. We just needed to be careful about what we do with the URLs that would be processed by the filter module. URLs wrapped in code tags or in comments should not be processed. We can go ahead and change them from http:// to https://.

For what it's worth, when I applied those four changes on my local environment and ran the FilterKernelTest it passed. You might apply the suggestions and give it a shot. If they don't work correctly, then they can always be reverted. I can try to help you figure out what went wrong with it too.

Applied the suggestions, Yours FilterKernelTest passed then i believe then it should work correctly, Thanks for the suggestions :)

It worked!!! All green, Thank you so much for those suggestions, will be forever grateful

You've done a good job here, performing due diligence to ensure everything is working correctly and to accept feedback. Thank you for being a helpful contributor. Please keep up the good work!

And now for my part: I have verified that the only remaining instances of http:\/\/(www\.)?test.com in Core are those that are supposed to be there for testing the filter module. These changes look good to me.

Hit me up on the Drupal Slack if you need help finding another issue to work on.

@dcam Thanks for positive review ,You were great too especially your helpfull nature, helping me with guidance and suggestions were very helpful, thanks to @quietone as well,
your slack id is @dcam right?

your slack id is @dcam right?

Yes

I have updated all occurrences of http://test.com and http://www.test.com to https across the codebase. As instructed, I explicitly excluded the vendor/ and node_modules/ directories.

Yes I directly jumped in doing MR @quietone as I believed and misinterpreted these issues to be an open mock issue for all the first timers. I wont repeat this thing again and will look forward to contribute the right way in future. Thanks )