Problem/Motivation

PHPUnit 12.5.0+ is changing the way that mock objects work:

  • Mock objects that do not configure expectations should be converted to stubs. Otherwise, they throw a notice: No expectations were configured for the mock object for \Drupal\comment\CommentManagerInterface. You should refactor your test code and use a test stub instead.
  • $this->any() is deprecated. It was equivalent to having no expectation, in which case the object should be a stub (see the previous bullet) or a more exact number of expectations should be added.
  • with() is deprecated for stubs because it was deemed to be equally pointless.

Steps to reproduce

  1. Require PHPUnit 12 with Composer.
  2. Fix compatibility issues with PHPUnit 12 by applying this patch.
  3. Run the Unit tests for a module with --display-phpunit-notices --display-phpunit-deprecations.
  4. Observe the PHPUnit notices that occur.

Proposed resolution

Fix notices in the system module.

Remaining tasks

Information on how to review these issues and the types of changes you're likely to find in them is included in the parent issue's comments.

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3569427

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dcam created an issue. See original summary.

dcam opened merge request !14487

dcam’s picture

dcam commented
Status: Active » Needs review
dcam’s picture

dcam commented
Issue summary: View changes
dcam’s picture

dcam commented
Status: Needs review » Needs work

Needs work due to PHPUnit 12.5.11 and a new deprecation.

dcam’s picture

dcam commented
Issue summary: View changes
Status: Needs work » Needs review

New development: stubs cannot set with(). The IS and MR have been updated.

dcam’s picture

dcam commented
Status: Needs review » Needs work

Needs Work for a rebase.

dcam’s picture

dcam commented
Status: Needs work » Needs review

Rebased

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

This one was easier to review because of the size. Conversions look good and make sense based on what I've been told. Also like using class names vs hardcoded strings.

LGTM

dcam’s picture

dcam commented

The baseline had to be updated following the commit of #3573259: Prevent new expects($this->any()) in tests which added new entries that are subsequently being removed by this MR.

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented

The MR has git conflict issue it couldn't be rebased from the browser UI.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
dcam’s picture

dcam commented
Status: Needs work » Reviewed & tested by the community

Rebased

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !14487

  • catch committed 3e2349d3 on main 
    task: #3569427 Convert expectation-less test mocks to stubs - System...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.