Closed (fixed)
Project:
Drupal core
Version:
11.x-dev
Component:
shortcut.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
23 Jan 2026 at 09:36 UTC
Updated:
24 Mar 2026 at 09:15 UTC
Jump to comment: Most recent
Comments
Comment #4
andypostI think few more tests could be moved but now it pass
Tests that should likely be moved to shortcut module
These are dedicated shortcut tests that would need to go with the module to contrib:
1. core/modules/navigation/tests/src/Functional/NavigationShortcutsBlockTest.php — Extensive testing of shortcuts in the Navigation block (creation, caching,
permissions, deletion). This is shortcut-specific test coverage.
2. core/modules/jsonapi/tests/src/Functional/JsonApiFilterRegressionTest.php — Has a test method that creates shortcut entities to test JSON:API filtering
(issue #3015759). Partial shortcut concern.
3. core/modules/filter/tests/src/Kernel/EntityLinksTest.php — Has a testShortcutEntity() method testing entity links with shortcuts.
Tests that reference shortcut but are testing other things
These just use shortcut as a dependency (e.g. for Claro schema validation) and would need to be updated to conditionally depend on or stop requiring shortcut:
- Claro theme tests (3 files) — install shortcut just for claro.settings schema validation
- ToolbarClaroOverridesTest.php — shortcut as dependency for toolbar testing
- NavigationBlockUiTest.php — shortcut permissions in modules list
- ConfigTranslationListUiTest.php — shortcut sets in config translation
- EntityOperationsCacheabilityTest.php — tests shortcut_set operations cacheability
- BigPipePlaceholderTestCases.php — hardcoded shortcut URL as test data
Recipe/installation tests #3571079: Remove Shortcut module from recipes
- StandardRecipeInstallTest.php and StandardRecipeTest.php — assert that 2 default shortcuts exist after Standard recipe install. These will need updating.
- ConfigActionValidationTest.php — tests shortcut_set config entity validation
Comment #5
andypostClaro related tests should stay here untouched so in deprecation issue/removal issue we can remove hardcoded config schema for
mobile_linkin third-party of theme settings and clean-upshortcut_install()from Claro chages (module already providing scherma for this link so oliviero theme can be cleaned too)Comment #6
smustgrave commentedThanks for picking these up @andypost
For deprecations I'll be doing several laps so will make sure we get the theme ones. I haven't opened a ticket yet as I'm waiting for more modules/lib components to land first as they also chip away at those.
Comment #7
catchNeeds a rebase for the phpstan baseline but otherwise looks good.
Comment #8
andypostrebased
Comment #10
longwaveCommitted 6e7257f and pushed to main. Thanks!
There is a conflict in the PHPStan baseline on 11.x, but this also needs to land there, so keeping open for backport.
Comment #13
andypostcherry-picked commit to new MR, tests running
Comment #14
smustgrave commentedThanks for taking care of this @andypost
Comment #15
quietone commentedComment #17
catchCommitted/pushed to 11.x, thanks!