Problem/Motivation

Part of removing Shortcut from core.

Steps to reproduce

Proposed resolution

Remove from umami and standard profiles

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3569133

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !14463

smustgrave made their first commit to this issue’s fork.

smustgrave’s picture

smustgrave commented

Thought I could make shortcut required, since migrate_drupal is being deprecated but really I just went down a never ending rabbit hole. But can't we remove migrations now?

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs work

needs rebase and more work

andypost’s picture

andypost
he/him
Primary language Russian
commented

rebased, trying to fix some tests

andypost’s picture

andypost
he/him
Primary language Russian
commented

Also it needs to change core/recipes/standard/recipe.yml probably remove shortcut

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#3571079: Remove Shortcut module from recipes
andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: Remove shortcut from umami and standard profile » Remove shortcut from umami and standard profile and recipe
Status: Needs work » Needs review

Created CR https://www.drupal.org/node/3575093

module should be removed from standard recipe the same time as from profile because StandardRecipeTest comparing profile and recipe installs.

Remaining clean-up of recipes will be done in #3571079: Remove Shortcut module from recipes

smustgrave’s picture

smustgrave commented

If we are removing from recipes might just complete rest of 3571079 it’s not a lot

andypost’s picture

andypost
he/him
Primary language Russian
commented

Looks like yes but what about removal of recipes?

I'm trying to add default shortcuts to some install hook, then will check

andypost’s picture

andypost
he/him
Primary language Russian
commented

added remaining changes and looks everythings is green)

smustgrave’s picture

smustgrave commented

On my phone but we good to close the recipes ticket then?

dcam’s picture

dcam commented

I haven't finished my review yet, but shouldn't the basic_shortcuts recipe be removed too?

andypost’s picture

andypost
he/him
Primary language Russian
commented

I think we should remove recipe in #3571079 or maybe move it to Drupal CMS when module will land in contrib

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

That sounds fine with me. To be honest I had to remind myself that the point of the issue was to remove Shortcut from the profiles. I believe that's been accomplished here. I didn't find any more references to shortcut in the two profiles or the standard recipe. I don't know of anything more to be done.

  • catch committed f1b477d7 on 11.x 
    task: #3569133 Remove shortcut from umami and standard profile and...

  • catch committed f5d6d7d9 on main 
    task: #3569133 Remove shortcut from umami and standard profile and...
catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !14463

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.