Problem/Motivation

Users can search with HTML markup in the query, and it appears in the output.

Steps to reproduce

Set up a search page, search for "hello" and see the output from Vertex has the markup.

This is more easily seen if using an API version of the search page.

Proposed resolution

Add an XSS filtering function to the query parameter, so it's not being returned.

Remaining tasks

Make a MR with the added code change.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork vertex_ai_search-3569086

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

samlerner created an issue. See original summary.

samlerner changed the visibility of the branch 1.0.x to hidden.

samlerner’s picture

samlerner commented
Status: Active » Needs review

Added a PR that implements XSS filtering on keyword input.

samlerner opened merge request !42

timozura made their first commit to this issue’s fork.

  • timozura committed e385eb86 on 1.0.x authored by samlerner 
    fix: #3569086 Add filtering to input variables for search queries

By:...
timozura’s picture

timozura commented
Version: 1.8.2 » 1.8.3
Status: Needs review » Fixed

Merged. Part of 1.8.3.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.