Problem/Motivation

#3560487: Gin Top Bar styling is fully gone in 11.3.x
The CSS file no longer exists in Gin 5.x
Warning: file_get_contents(themes/contrib/gin/styles/admin-reset-styles.css): Failed to open stream

Steps to reproduce

Update to the latest Gin and Varbase core, and review logged errors and toolbar issues.

Proposed resolution

Remove the forced lines from varbase_admin to load the admin-reset-styles.css file.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ❌ Release varbase-10.1.1, varbase_core-10.1.63

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

CommentFileSizeAuthor
#2 varbase_admin-fix-gin-admin-reset-styles.patch622 bytesn.ghunaim

Issue fork varbase_core-3569005

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

n.ghunaim created an issue. See original summary.

n.ghunaim’s picture

n.ghunaim commented
StatusFileSize
new varbase_admin-fix-gin-admin-reset-styles.patch622 bytes

uploaded a patch to fix the issue. Please review.

n.ghunaim’s picture

n.ghunaim commented
Status: Active » Needs review

abu-zakham made their first commit to this issue’s fork.

abu-zakham opened merge request !60

rajab natshah’s picture

rajab natshah
he/him
commented
Title: Warning: file_get_contents(themes/contrib/gin/styles/admin-reset-styles.css): Failed to open stream » warning message related admin-reset-styles.css file
Issue summary: View changes

#3560487: Gin Top Bar styling is fully gone in 11.3.x

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
Issue tags: +varbase-10.1.1, +varbase_core-10.1.63
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: Unassigned » josebc
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: josebc » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes

✅ Released varbase_core-10.1.63

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.