Problem/Motivation

The module dependencies listed in the info file can conflict with different use cases, e.g. using a dev snapshot of Commerce.

Steps to reproduce

Download a dev version of Commerce via composer.
Try to enable the module

Proposed resolution

Remove the version restriction from commerce_order_item_ui.info.yml.

Remaining tasks

Remove the version restriction from commerce_order_item_ui.info.yml.

User interface changes

n/a

API changes

n/a

Data model changes

n/a

Issue fork commerce_order_item_ui-3568753

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

damienmckenna created an issue. See original summary.

damienmckenna opened merge request !3

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
plopesc’s picture

plopesc
he/him
Primary language Spanish
commented

Thank you for the MR.

That requirement was there because the module requires #3398919: Unable to add order line item without overriding the unit price in custom form. And it was included in 2.37.

We might think about removing that constraint now, that 2.40 & 3.x are already available.

Do you think it might be possible to find a way that would allow your scenario while preventing <2.37?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Shouldn't the composer.json restrictions be enough to control the module versions?

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs review » Reviewed & tested by the community

You're right. Marking as RTBC.

Thank you for the heads up.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Reviewed & tested by the community » Fixed

MR merged and released v1.2.2. https://www.drupal.org/project/commerce_order_item_ui/releases/1.2.2

Thank you!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.