Problem/Motivation

When visiting /admin/config/domain/config-ui, a PHP warning is triggered twice:

Warning: Undefined array key "#title" in Drupal\Core\Form\ConfigFormBase->checkConfigOverrides() (line 363 of core/lib/Drupal/Core/Form/ConfigFormBase.php)

This occurs because the path_pages textarea element in SettingsForm::buildForm() has a #config_target but no #title property. When Drupal core's ConfigFormBase::checkConfigOverrides() processes form elements with configuration overrides, it assumes all elements have a #title property (introduced in #2408549).

Drupal Version

10.6.2

Domain module version

2.0.0-rc1

Actual Behavior

Warning: Undefined array key "#title" in Drupal\Core\Form\ConfigFormBase->checkConfigOverrides() (line 363 of core/lib/Drupal/Core/Form/ConfigFormBase.php)

Steps to reproduce

1. Install Domain and Domain Config UI modules
2. Visit /admin/config/domain/config-ui
3. Observe PHP warnings in logs

CommentFileSizeAuthor
domain_missing-title.patch496 bytesfox mulder

Issue fork domain-3568549

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fox mulder created an issue. See original summary.

mably made their first commit to this issue’s fork.

mably opened merge request !300

mably’s picture

mably commented

Hi @fox-mulder, can you give a try to this issue's MR please?

You can check it using this issue's Tugboat live preview (login: admin/admin).

mably’s picture

mably commented
Status: Active » Needs review

mably opened merge request !303

mably changed the visibility of the branch 3568549-undefined-array-key to hidden.

fox mulder’s picture

fox mulder commented

Hi @mably, MR !303 solves the issue.

mably’s picture

mably commented

Cool, thanks for the feedback @fox-mulder, let's merge it!

mably’s picture

mably commented
Status: Needs review » Reviewed & tested by the community

  • mably committed 2db2367a on 2.0.x 
    fix: #3568549 Undefined array key "#title" warning in domain_config_ui...
mably’s picture

mably commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

mably’s picture

mably commented
Status: Fixed » Closed (fixed)