Problem/Motivation

https://typesense.org/docs/30.0/api/#deprecations-behavior-changes

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork search_api_typesense-3568471

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lussoluca created an issue. See original summary.

nickolaj made their first commit to this issue’s fork.

nickolaj opened merge request !69

nickolaj’s picture

nickolaj
Primary language Ukrainian
commented
Status: Active » Needs review

Updated composer.json to allow typesense-php ^6.0 (in addition to ^5.1) which adds support for Typesense Server 30.x. The PHP client v6 maintains backward compatibility with the collection-scoped synonym and override APIs.

lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
commented
Status: Needs review » Needs work

This is not enough, for example, the deleteAllIndexItems method inSearchApiTypesenseBackend uses getTypesenseClient()->exportCollectionData to export data before deleting a collection. exportCollectionData uses $collection->synonyms->retrieve()['synonyms'] to extract synonyms, but this endpoint is not valid anymore.
It seems that in v6, new APIs were added, but old APIs were not removed.

We need to decide if we should release a new version of the module that is compatible with Typesense >30 only, or to support both versions with the same codebase

lussoluca closed merge request !69

lussoluca opened merge request !72

lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
commented
Status: Needs work » Fixed

Committed to 1.2.0-beta1. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.