Problem/Motivation

Discovered as a side effect of #3291519: Fix remaining method.notFound PHPStan L0 errors

https://git.drupalcode.org/issue/drupal-3291519/-/jobs/8117075

    Jquery Ui Library Assets (Drupal\FunctionalTests\Libraries\JqueryUiLibraryAssets)
     ✔ Properly set weights
     ⚠ Same asset same weight
     ✔ Library asset loading order with drupal.autocomplete
     ✔ Library asset loading order with drupal.dialog
     ✔ Library asset loading order with drupal.autocomplete|drupal.dialog
     ✔ Asset loading unchanged with drupal.autocomplete
     ✔ Asset loading unchanged with drupal.dialog
     ✔ Asset loading unchanged with drupal.autocomplete|drupal.dialog
    
    There was 1 risky test:
    
    1) Drupal\FunctionalTests\Libraries\JqueryUiLibraryAssetsTest::testSameAssetSameWeight
    This test did not perform any assertions

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3568287

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

I don't think this test has been useful since #3277744: Actually remove deprecated jquery_ui libraries from core, let's just delete it.

longwave opened merge request !14402

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Agree it seems left over from a while ago.

  • catch committed ff70e39a on 11.x 
    fix: #3568287 JqueryUiLibraryAssetsTest::testSameAssetSameWeight() tests...

  • catch committed 2e3ff382 on main 
    fix: #3568287 JqueryUiLibraryAssetsTest::testSameAssetSameWeight() tests...

catch closed merge request !14402

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.